On Tue, Oct 20, 2015 at 06:13:35PM +0300, Sagi Grimberg wrote: >> The networking community will let you work for 10y before they add a >> field to struct net_device exactly b/c >> of the reason I brought. Why here we can come out of the blue and add >> tens if not hundreds of fields to our device structure? > > Keeping struct ib_device_attr embedded at the end of struct ib_device is > exactly the same isn't it?
In terms of layout it is, in terms of usability it's worse. Just to take the networking example Or seems to like so much there is no struct netdev_attr to which fields of struct netdev are moved out to, which you then need to query and cache anyway in your private device structure. This design simply was a idiotic idea to start with and I don't understand why anyone would han onto it. I do understand Chuck's concern about churn, but I'd rather fix the infiniband subsystem up before we're growing even more users. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
