On Wed, Nov 25, 2015 at 10:48 AM, Sagi Grimberg <sa...@dev.mellanox.co.il> wrote: > On 25/11/2015 10:41, Or Gerlitz wrote: >> On Wed, Nov 25, 2015 at 9:55 AM, Sagi Grimberg <sa...@dev.mellanox.co.il> >> wrote:
>> I see, so if this is case, can you eliminate one the checks here >>>>> + if (isert_conn->snd_w_inv && isert_cmd->inv_rkey) { > This are *exactly* the checks that enforce what I said above. > If we remove that we'd step on the bug you mentioned. > We do remote invalidate only if: > - we are allowed to (send_w_inv) > - initiator passed us rkey (inv_rkey). yep, should be probably OK. You didn't respond to my comment re adding bools vs bit-fields vs bit-flags Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html