Hello all, On Sat, Dec 12, 2015 at 5:26 AM, ira.weiny <ira.we...@intel.com> wrote: > On Fri, Dec 11, 2015 at 12:25:35PM -0600, Christoph Lameter wrote: >> Display the additional 64 bit counters available through the extended >> set and replace the existing 32 bit counters if there is a 64 bit >> alternative available. >> >> Note: This requires universal support of extended counters in >> the devices. If there are still devices around that do not >> support extended counters then we will have to add some fallback >> technique here. > > Looks like ocrdma will break here.
Yes, today we report 32 bit counters and to support this change a simple patch is needed to replace those cpu_to_be32() with cpu_to_be64(). Internally we already have 64bit countes. > > I'm not sure about mthca. > > qib, mlx4 are fine. mlx5 should be as well I would think (I don't have that > hardware.) > > hfi1 did not process these MADs previously as all the hardware counters are 64 > bits. But with this patch series we would add it. > > ehca, amso1100, and ipath are all gone so they don't matter. > > I can whip up a patch for hfi1 and we have to wait for Doug to take over that > driver anyway to make sure that the patch would apply. So I think you can > ignore it. > > ocrdma seems like it could be a quick patch pre this one. > > Ira > >> >> Signed-off-by: Christoph Lameter <c...@linux.com> >> --- >> drivers/infiniband/core/sysfs.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/infiniband/core/sysfs.c >> b/drivers/infiniband/core/sysfs.c >> index 0083a4f..f7f2954 100644 >> --- a/drivers/infiniband/core/sysfs.c >> +++ b/drivers/infiniband/core/sysfs.c >> @@ -406,10 +406,14 @@ static PORT_PMA_ATTR(port_rcv_constraint_errors , >> 8, 8, 136, IB_PMA_PORT_C >> static PORT_PMA_ATTR(local_link_integrity_errors , 9, 4, 152, >> IB_PMA_PORT_COUNTERS); >> static PORT_PMA_ATTR(excessive_buffer_overrun_errors, 10, 4, 156, >> IB_PMA_PORT_COUNTERS); >> static PORT_PMA_ATTR(VL15_dropped , 11, 16, 176, >> IB_PMA_PORT_COUNTERS); >> -static PORT_PMA_ATTR(port_xmit_data , 12, 32, 192, >> IB_PMA_PORT_COUNTERS); >> -static PORT_PMA_ATTR(port_rcv_data , 13, 32, 224, >> IB_PMA_PORT_COUNTERS); >> -static PORT_PMA_ATTR(port_xmit_packets , 14, 32, 256, >> IB_PMA_PORT_COUNTERS); >> -static PORT_PMA_ATTR(port_rcv_packets , 15, 32, 288, >> IB_PMA_PORT_COUNTERS); >> +static PORT_PMA_ATTR(port_xmit_data , 0, 64, 64, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(port_rcv_data , 0, 64, 128, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(port_xmit_packets , 0, 64, 192, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(port_rcv_packets , 0, 64, 256, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(unicast_xmit_packets , 0, 64, 320, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(unicast_rcv_packets , 0, 64, 384, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(multicast_xmit_packets , 0, 64, 448, >> IB_PMA_PORT_COUNTERS_EXT); >> +static PORT_PMA_ATTR(multicast_rcv_packets , 0, 64, 512, >> IB_PMA_PORT_COUNTERS_EXT); >> >> static struct attribute *pma_attrs[] = { >> &port_pma_attr_symbol_error.attr.attr, >> @@ -428,6 +432,10 @@ static struct attribute *pma_attrs[] = { >> &port_pma_attr_port_rcv_data.attr.attr, >> &port_pma_attr_port_xmit_packets.attr.attr, >> &port_pma_attr_port_rcv_packets.attr.attr, >> + &port_pma_attr_unicast_rcv_packets.attr.attr, >> + &port_pma_attr_unicast_xmit_packets.attr.attr, >> + &port_pma_attr_multicast_rcv_packets.attr.attr, >> + &port_pma_attr_multicast_xmit_packets.attr.attr, >> NULL >> }; >> >> -- >> 2.5.0 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html