> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> > Since you and Jason did not reach a consensus, I have to dig in and > > see if these patches make it possible to break namespace confinement, > > either accidentally or with intentionally tricky behavior. That's > > going to take me some time. > > Everything to do with parsing a wc and constructing an AH is wrong in this > series, and the fixes require the API changes I mentioned ( add 'wc to gid > index' API call, add 'route to AH' API call) > > Every time you read 'route validation' - that is an error, the route should > never just be validated, it is needed information to construct a rocev2 AH. > All > the places that roughly hand parse the rocev2 WC should not be open coded. > > Even if current HW is broken for namespaces we should not enshrine that in > the kapi. > Currently, namespaces are not supported for RoCE. So for this patches, this is irrelevant. That said, we have everything we need for RoCE namespace support when we get there. All of this has nothing to do with "broken" and enshrining anything in the kapi. That's just bullshit. The crux of the discussion is the meaning of the API. The design of the RDMA stack is that Verbs are used by core IB services, such as addressing. For these services, as the specification requires, all relevant fields must be reported in the CQE, period. All spec-compliant HW devices follow this. If a ULP wants to create an address handle from a completion, there are service routines to accomplish that, based on the reported fields. If it doesn't care, there is no reason to sacrifice performance. --Liran -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
