On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny <ira.we...@intel.com> wrote: > On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: >> From: Leon Romanovsky <leo...@mellanox.com> >> >> Modify enum ib_device_cap_flags such that other patches which add new >> enum values pass strict checkpatch.pl checks. >> .... >> - IB_DEVICE_RESERVED = (1<<16), /* old SEND_W_INV */ >> - IB_DEVICE_MEM_WINDOW = (1<<17), >> + IB_DEVICE_RESIZE_MAX_WR = (1 << 0), > > NIT: Shouldn't we just use the BIT macro? > > IB_DEVICE_RESIZE_MAX_WR = BIT(0), You are right and it is a preferred way for me too, however the downside of such change will be one of two: 1. Change this structure only => we will have style mix of BITs and shifts in the same file. IMHO it looks awful. 2. Change the whole file => the work with "git blame" will be less straightforward.
I will do the change across whole file, If Doug accepts such change. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
