[PATCH v2 2/2] remoteproc: qcom: adsp: Remove subdevs on the error path of adsp_probe()

[Joe Hattori]

Current implementation of adsp_probe() in qcom_q6v5_adsp.c and does not
remove the subdevs of adsp on the error path. Fix this bug by calling
qcom_remove_{ssr,sysmon,pdm,smd,glink}_subdev(), and qcom_q6v5_deinit()
appropriately.

Fixes: dc160e449122 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver")
Signed-off-by: Joe Hattori <j...@pf.is.s.u-tokyo.ac.jp>
---
 drivers/remoteproc/qcom_q6v5_adsp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c 
b/drivers/remoteproc/qcom_q6v5_adsp.c
index 572dcb0f055b..223f6ca0745d 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -734,15 +734,22 @@ static int adsp_probe(struct platform_device *pdev)
                                              desc->ssctl_id);
        if (IS_ERR(adsp->sysmon)) {
                ret = PTR_ERR(adsp->sysmon);
-               goto disable_pm;
+               goto deinit_remove_glink_pdm_ssr;
        }
 
        ret = rproc_add(rproc);
        if (ret)
-               goto disable_pm;
+               goto remove_sysmon;
 
        return 0;
 
+remove_sysmon:
+       qcom_remove_sysmon_subdev(adsp->sysmon);
+deinit_remove_glink_pdm_ssr:
+       qcom_q6v5_deinit(&adsp->q6v5);
+       qcom_remove_glink_subdev(rproc, &adsp->glink_subdev);
+       qcom_remove_pdm_subdev(rproc, &adsp->pdm_subdev);
+       qcom_remove_ssr_subdev(rproc, &adsp->ssr_subdev);
 disable_pm:
        qcom_rproc_pds_detach(adsp);
 
-- 
2.34.1