On 03/04/2025 14:03, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu <[email protected]> > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu <[email protected]> > Signed-off-by: Gokul Sriram Palanisamy <[email protected]> > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 61 ++++++++++++++++++++++++++- > 1 file changed, 60 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index db69bff41afa..11a1849ec50f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -3,7 +3,7 @@ > * IPQ9574 SoC device tree source > * > * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved. > - * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights > reserved. > + * Copyright (c) 2023-2025, Qualcomm Innovation Center, Inc. All rights > reserved. > */ > > #include <dt-bindings/clock/qcom,apss-ipq.h> > @@ -226,6 +226,11 @@ smem@4aa00000 { > hwlocks = <&tcsr_mutex 3>; > no-map; > }; > + > + q6_region: wcss@4ab00000 { > + reg = <0x0 0x4ab00000 0x0 0x2b00000>; > + no-map; > + }; > }; > > soc: soc@0 { > @@ -1473,6 +1478,36 @@ top_glue-critical { > }; > }; > }; > + > + q6v5_wcss: remoteproc@cd00000 { > + compatible = "qcom,ipq9574-wcss-sec-pil"; > + reg = <0x0cd00000 0x4040>;
So this obviously was never built tested :/ I don't understand why bindings and DTS is being changed after half a year. You got already review and what you sent supposed to be complete. Now, half a year later, you change both bindings and DTS thus: 1. What was the point of reviewing it that time? I will skip reviewing next time and wait till your patchsets reach v4 or v8 and review only then. This is not the first time for IPQ patches. It is actually pattern. 2. How released hardware can change within this timeframe? Best regards, Krzysztof
