Re: [PATCH] remoteproc: k3: Fix NULL vs IS_ERR() bug in k3_reserved_mem_init()

[Mathieu Poirier]

On Fri, Feb 27, 2026 at 05:21:10PM +0800, Chen Ni wrote:
> The devm_ioremap_resource_wc() function never returns NULL, it returns
> error pointers.  Update the error checking to match.
> 
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for 
> "memory-region"")
> Signed-off-by: Chen Ni <nic...@iscas.ac.cn>
> ---
>  drivers/remoteproc/ti_k3_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

I have applied both patches.

Thanks,
Mathieu
 
> diff --git a/drivers/remoteproc/ti_k3_common.c 
> b/drivers/remoteproc/ti_k3_common.c
> index 32aa954dc5be..3cb8ae5d72f6 100644
> --- a/drivers/remoteproc/ti_k3_common.c
> +++ b/drivers/remoteproc/ti_k3_common.c
> @@ -513,7 +513,7 @@ int k3_reserved_mem_init(struct k3_rproc *kproc)
>               kproc->rmem[i].dev_addr = (u32)res.start;
>               kproc->rmem[i].size = resource_size(&res);
>               kproc->rmem[i].cpu_addr = devm_ioremap_resource_wc(dev, &res);
> -             if (!kproc->rmem[i].cpu_addr) {
> +             if (IS_ERR(kproc->rmem[i].cpu_addr)) {
>                       dev_err(dev, "failed to map reserved memory#%d at 
> %pR\n",
>                               i + 1, &res);
>                       return -ENOMEM;
> -- 
> 2.25.1
>