On Fri, Feb 27, 2026 at 05:15:46PM +0800, Chen Ni wrote:
> The devm_ioremap_resource_wc() function never returns NULL, it returns
> error pointers.  Update the error checking to match.
>
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for 
> "memory-region"")
> Signed-off-by: Chen Ni <[email protected]>
> ---

Reviewed-by: Frank Li <[email protected]>

>  drivers/remoteproc/imx_rproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index d33d1e2c41a4..0dd80e688b0e 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -812,7 +812,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
>
>               /* Not use resource version, because we might share region */
>               priv->mem[b].cpu_addr = devm_ioremap_resource_wc(&pdev->dev, 
> &res);
> -             if (!priv->mem[b].cpu_addr) {
> +             if (IS_ERR(priv->mem[b].cpu_addr)) {
>                       dev_err(dev, "failed to remap %pr\n", &res);
>                       return -ENOMEM;
>               }
> --
> 2.25.1
>

Reply via email to