Hi, 2016-03-15 5:48 GMT+09:00 Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>: > Hello. > > > On 03/13/2016 09:11 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error, gPTP) >> - One interrupt for emac >> - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) >> >> This patch improve efficiency of the interrupt handler by adding the >> interrupt handler corresponding to each interrupt source described >> above. Additionally, it reduces the number of times of the access to >> EthernetAVB IF. >> Also this patch prevent this driver depends on the whim of a boot loader. >> >> [ykaneko0...@gmail.com: define bit names of registers] >> [ykaneko0...@gmail.com: add comment for gen3 only registers] >> [ykaneko0...@gmail.com: fix coding style] >> [ykaneko0...@gmail.com: update changelog] >> [ykaneko0...@gmail.com: gen3: fix initialization of interrupts] >> [ykaneko0...@gmail.com: gen3: fix clearing interrupts] >> [ykaneko0...@gmail.com: gen3: add helper function for request_irq()] >> [ykaneko0...@gmail.com: gen3: remove IRQF_SHARED flag for request_irq()] >> [ykaneko0...@gmail.com: revert ravb_close() and ravb_ptp_stop()] >> [ykaneko0...@gmail.com: avoid calling free_irq() to non-hooked interrupts] >> [ykaneko0...@gmail.com: make NC/BE interrupt handler a function] >> [ykaneko0...@gmail.com: make timestamp interrupt handler a function] >> [ykaneko0...@gmail.com: timestamp interrupt is handled in multiple >> interrupt handler instead of dma queue interrupt handler] >> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0...@gmail.com> > > [...] >> >> diff --git a/drivers/net/ethernet/renesas/ravb_main.c >> b/drivers/net/ethernet/renesas/ravb_main.c >> index 8f2c4fb..8fa8ffe 100644 >> --- a/drivers/net/ethernet/renesas/ravb_main.c >> +++ b/drivers/net/ethernet/renesas/ravb_main.c > > [...] >> >> @@ -757,14 +806,73 @@ static irqreturn_t ravb_interrupt(int irq, void >> *dev_id) >> result = IRQ_HANDLED; >> } >> >> - if (iss & ISS_CGIS) >> - result = ravb_ptp_interrupt(ndev); >> + /* gPTP interrupt status summary */ >> + if ((iss & ISS_CGIS) && ravb_ptp_interrupt(ndev) == IRQ_HANDLED) >> + result = IRQ_HANDLED; > > > Wait, this seems like a bug in the existing driver! Please do fix it with > a separate patch against net.git. Sorry about missing (or even adding) it > while cleaning up the driver before submission...
Thanks, I will do so. > > [...] > > Looks fine otherwise, however the new features and the fixes shouldn't be > mixed together, so I couldn't ACK yet. I'll go test it on gen2... Thanks in advance. > > MBR, Sergei > Thanks, kaneko
