Hi Geert, Thanks for your review.
On 2016-09-05 17:54:44 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Mon, Sep 5, 2016 at 4:19 PM, Niklas Söderlund > <[email protected]> wrote: > > The pinconf-generic code expects configurations with arguments to be > > returned in a packed format in order to be displayed properly by > > pinconf_generic_dump_one(). > > Some more user-oriented explanation could be helpful, like saying that > /sys/kernel/debug/pinctrl/e6060000.pfc/pinconf-pins on r8a7795/salvator-x now > shows > > pin 96 (GP_3_0): input bias disabled, output drive strength (9 > mA), pin power source (3300 selector) > > instead of > > pin 96 (GP_3_0): input bias disabled, output drive strength (0 > mA), pin power source (0 selector) Good idea, I will send a v2 with a more user-oriented explanation. > > > Signed-off-by: Niklas Söderlund <[email protected]> > > Tested-by: Geert Uytterhoeven <[email protected]> Thanks for testing. > > P.S. It seems like we should get rid of the WARN_ON_ONCE() checks in our > pinctrl code, and return proper errors, as these are triggered by reading > the sysfs files. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds -- Regards, Niklas Söderlund
