On 13 September 2016 at 17:59, Chris Brandt <chris.bra...@renesas.com> wrote: > Hello Uffe > > Thank you for your reply. > > On 9/13/2016, Ulf Hansson wrote: >> Because, if you have an external regulator feeding the mmc with power you >> should set it up and use it. > > But in many board designs, there is no control over the regulator supply (or > you would rather have your bootloader do that, not the kernel). > > So what this patch is doing is setting it to a default of 3.3v (for just this > SoC) and if someone wants to add a regulator in the board's DT file, that > will override the ocr_mask set by the driver.
That's perfectly okay to me! I just wanted to get clear picture of *why* this change was needed. > > > I'm assuming I'll have to do the same for MMC (sh_mmcif.c) once I get to that > driver (I need to find my MMC PLUS card first for testing). Okay! Kind regards Uffe
