Hi Sergei, On Sat, Sep 30, 2017 at 12:24 PM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > On 9/29/2017 2:52 PM, Simon Horman wrote: >> From: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> >> >> This patch enables EthernetAVB for R-Car D3 draak board. >> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> >> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> >> Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > [...] >> >> @@ -37,6 +39,14 @@ >> }; >> &pfc { >> + avb0_pins: avb { >> + mux { >> + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > ^^^^^^^^^^^^^^ > Hum, I don't think it's compatible with routing the PHY interrupt via > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT > anyway. Seems we have the same issue in arch/arm64/boot/dts/renesas/ulcb.dtsi and arch/arm64/boot/dts/renesas/salvator-common.dtsi? >> +&avb { >> + phy0: ethernet-phy@0 { >> + rxc-skew-ps = <1500>; >> + reg = <0>; >> + interrupt-parent = <&gpio5>; >> + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; >> + }; >> +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds