On 10/16/2017 04:55 PM, Geert Uytterhoeven wrote:

Currently, if Wake-on-LAN is enabled, the EtherAVB device's module clock
is manually kept running during system suspend, to make sure the device
stays active.

Since "soc: renesas: rcar-sysc: Keep wakeup sources active during system
suspend", this workaround is no longer needed.  Hence remove all
explicit clock handling to keep the device active.

Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
[...]

Reviewed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>

diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index fdf30bfa403bf416..11ffccca11d56df5 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
[...]
@@ -2289,8 +2283,6 @@ static int __maybe_unused ravb_resume(struct device *dev)
                 *       this clock dance should be removed.
                 */
                clk_disable(priv->clk);
-               clk_disable(priv->clk);
-               clk_enable(priv->clk);
                clk_enable(priv->clk);

   I thought the entire clock dance could be removed now? Not yet?

[...]

MBR, Sergei

Reply via email to