> > You need to fix the kerneldoc for 'gpiod_get_direction", too. It still
> > mentions GPIOF_DIR_*.
> 
> More places? I can't find them!

drivers/gpio/gpiolib.c

Line 198 in both 4.15-rc3 and linux-next.

Or as I said, the kerneldoc of gpiod_get_direction ;)

> Together with Geert's comments I start to lean towards actually
> just creating two new #defines in <linux/consumer.h>.
> 
> It has the upside that we can also check the return value
> for errors.

Sounds good, in deed.

Attachment: signature.asc
Description: PGP signature

Reply via email to