On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote:
> No reason to have them undefined, so let's add them.
> 

>       int (*recover_bus)(struct i2c_adapter *);
>  
> -     int (*get_scl)(struct i2c_adapter *);
> -     void (*set_scl)(struct i2c_adapter *, int val);
> -     int (*get_sda)(struct i2c_adapter *);
> +     int (*get_scl)(struct i2c_adapter *adap);
> +     void (*set_scl)(struct i2c_adapter *adap, int val);
> +     int (*get_sda)(struct i2c_adapter *adap);
>  
>       void (*prepare_recovery)(struct i2c_adapter *);
>       void (*unprepare_recovery)(struct i2c_adapter *);

It seems inconsistent with the rest of the members even from this
visible piece.

-- 
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy

Reply via email to