On 02/22/2018 07:32 PM, Laurent Pinchart wrote: > From: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > and VSP2-D instances") added support for the VSP2-D found in the R-Car > V3M (R8A77970) but the video output that VSP2-D sends to DU has a greenish > garbage-like line repeated every 8 screen rows. It turns out that R-Car > V3M has the LIF0 buffer attribute register that you need to set to a non- > default value in order to get rid of the output artifacts. > > Based on the original (and large) patch by Daisuke Matsushita > <daisuke.matsushita...@hitachi.com>. > > Fixes: d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and > VSP2-D instances") > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > [Removed braces, added VI6_IP_VERSION_MASK to improve readabiliy] > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
[...] > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h > b/drivers/media/platform/vsp1/vsp1_regs.h > index b1912c83a1da..dae0c1901297 100644 > --- a/drivers/media/platform/vsp1/vsp1_regs.h > +++ b/drivers/media/platform/vsp1/vsp1_regs.h [...] > @@ -705,6 +710,7 @@ > */ > > #define VI6_IP_VERSION 0x3f00 > +#define VI6_IP_VERSION_MASK (0xffff << 0) Perhaps (VI6_IP_VERSION_MODEL_MASK | VI6_IP_VERSION_SOC_MASK) would be clearer? MBR, Sergei