On 2018-04-30 14:08, Wolfram Sang wrote: > The demux device is only a logical device with no children. So, no > RuntimePM is needed, let's disable the sysfs interface for it. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > --- > > I think it is proper to just disable the interface without enabling RPM at > all. > USB and PCIE core do this as well. Still, adding PM and Rafael to CC in case > we > all got it wrong.
Sounds ok to me. I'm not fluent with PM stuff, but I trust your judgement. Applied to i2c-mux/for-next. Cheers, Peter > drivers/i2c/muxes/i2c-demux-pinctrl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c > b/drivers/i2c/muxes/i2c-demux-pinctrl.c > index 61440a9507e4..d5e7d4aa6ee1 100644 > --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c > +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c > @@ -18,6 +18,7 @@ > #include <linux/of.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/slab.h> > #include <linux/sysfs.h> > > @@ -262,6 +263,8 @@ static int i2c_demux_pinctrl_probe(struct platform_device > *pdev) > > platform_set_drvdata(pdev, priv); > > + pm_runtime_no_callbacks(&pdev->dev); > + > /* switch to first parent as active master */ > i2c_demux_activate_master(priv, 0); > >
