Hi Wolfram-san,
Thank you for the patch!
> From: Wolfram Sang, Sent: Tuesday, May 29, 2018 7:59 PM
> Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3
If possible, I'd like to replace "bug" with "specification" or other words :)
<snip>
> @@ -743,6 +753,16 @@ static int rcar_i2c_master_xfer(struct i2c_adapter *adap,
>
> pm_runtime_get_sync(dev);
>
> + /* Gen3 has a HW bug which needs a reset before allowing RX DMA once */
> + if (priv->devtype == I2C_RCAR_GEN3) {
> + priv->flags |= ID_P_NO_RXDMA;
> + if (!IS_ERR(priv->rstc)) {
> + ret = reset_control_reset(priv->rstc);
According to the datasheet Rev.1.00 page 57-69, we should do:
reset_control_assert();
udelay(1);
reset_control_deassert();
while (reset_control_status())
;
instead of reset_control_reset(), I think.
Best regards,
Yoshihiro Shimoda
