Hi Biju,

On Thu, Aug 2, 2018 at 4:17 PM Biju Das <biju....@bp.renesas.com> wrote:
> Describe GPIO blocks in the R8A77470 device tree.
>
> Signed-off-by: Biju Das <biju....@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>

> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi

> +               gpio3: gpio@e6053000 {
> +                       compatible = "renesas,gpio-r8a77470",
> +                                    "renesas,rcar-gen2-gpio";
> +                       reg = <0 0xe6053000 0 0x50>;
> +                       interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +                       #gpio-cells = <2>;
> +                       gpio-controller;
> +                       gpio-reserved-ranges = <17 10>;
> +                       gpio-ranges = <&pfc 0 96 30>;

I would reverse the order of these two properties, but that's purely cosmetic.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to