On Fri, Aug 10, 2018 at 09:50:15AM -0600, Rob Herring wrote: > On Fri, Aug 10, 2018 at 5:13 AM Simon Horman <ho...@verge.net.au> wrote: > > > > On Fri, Aug 10, 2018 at 07:37:18AM +0000, Biju Das wrote: > > > Hi Rob, > > > > > > > Subject: Re: [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 > > > > support > > > > > > > > Hi, this is an automated email from Rob's (experimental) review bot. I > > > > found > > > > a couple of common problems with your patch. Please see below. > > > > > > Do I need to send another patch? The mail says " Rob's (experimental) > > > review bot". Previously for RZ/G1C upstreaming I have submitted the > > > patches in similar fashion. Is anything changed? > > > > Yes, indeed. > > > > At one point I was enforcing such a split but as it did not seem to be a > > universal practice I stopped doing so. I'd like some clear guidance from > > Rob if he'd like this split to occur going forwards. > > I've generally not asked for either of these on 1 (or few) line > changes or if I had no other comments on the patch. But for automated > checking I'm not going to try to make that distinction. So, still up > to whomever applies them. > > BTW, I'm adding the splitting patches check to checkpatch.pl too.
Thanks, it sounds to me that splitting things will be the cleanest approach for future patches. We'll see how that goes.
