On Thu, Aug 16, 2018 at 04:16:37PM +0900, Masahiro Yamada wrote: > renesas_sdhi_clk_start() and renesas_sdhi_clk_stop() are now only > called from renesas_sdhi_set_clock(). Merge them.
I can see the benefit of this change...
> static void renesas_sdhi_set_clock(struct tmio_mmc_host *host,
> unsigned int new_clock)
> {
> u32 clk = 0, clock;
>
> - if (new_clock == 0) {
> - renesas_sdhi_clk_stop(host);
> - return;
> - }
> + sd_ctrl_write16(host, CTL_SD_CARD_CLK_CTL, ~CLK_CTL_SCLKEN &
> + sd_ctrl_read16(host, CTL_SD_CARD_CLK_CTL));
> +
> + if (new_clock == 0)
> + goto out;
... yet there is a slight change in that we disable the clock a tad
earlier now. I need to check the datasheets tomorrow what is exactly
documented and report back.
signature.asc
Description: PGP signature
