On Fri, Aug 31, 2018 at 12:49:08PM +0200, Niklas Söderlund wrote: > On 2018-08-31 12:35:24 +0200, Wolfram Sang wrote: > > > > > Promote > > > drivers/gpu/drm/exynos/exynos_drm_iommu.c:configure_dma_max_seg_size() > > > to a generic helper? > > > > Yes! > > > If that is promoted should not > drivers/gpu/drm/exynos/exynos_drm_iommu.c:clear_dma_max_seg_size() also > be promoted? And if so should this patch revert back to v1 with a custom > remove function which clears and free the dma_parms ?
My preference would be easy to use helpers for drivers because this is easy to get wrong. I think we need to discuss with the creators of that API: a) if the drm/exynos driver does the right thing(tm) b) if these functions should be generic helpers c) when to clear the pointer (a bit related to a)) Niklas, do you have an interest to do that? Or would you rather go with SDHI hacking? :) I can do it, too.
signature.asc
Description: PGP signature
