Hi Fabrizio, Hi Geert, On Wed, Sep 19, 2018 at 10:21:13AM +0000, Fabrizio Castro wrote: > Hello Geert, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > Your proposal is with me, Simon do you want me to send a v2 for this?
Thanks, I have applied this for v4.20 with the updated subject and Geert's review tag. > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > <fabrizio.cas...@bp.renesas.com> wrote: > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > > > Reviewed-by: Biju Das <biju....@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> ... On Wed, Sep 19, 2018 at 10:24:00AM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > > <fabrizio.cas...@bp.renesas.com> wrote: > > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > > > > Reviewed-by: Biju Das <biju....@bp.renesas.com> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > > > > I would like to ask to what extent this has been tested with respect to > > CPU hotplug, suspend to RAM, and combinations thereof. > > Both CPU hotplug and STR were tested on their own and combined, I haven't > encountered any issue so far. On Wed, Sep 19, 2018 at 10:32:24AM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote: > > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > > > <fabrizio.cas...@bp.renesas.com> wrote: > > > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > > > > > Reviewed-by: Biju Das <biju....@bp.renesas.com> > > > > > > > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > > > > > > I would like to ask to what extent this has been tested with respect to > > > CPU hotplug, suspend to RAM, and combinations thereof. > > > > And any details of firmware, bootloader, ... version stacks where this is > > supported. > > iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25 > U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39) > > # cat /sys/devices/soc0/revision > ES2.0 > > I hope this helps. Thanks for your follow-up on the testing and environment, it does indeed help to give me confidence when applying this patch. ...
