On 10/10/2018 01:57 PM, Niklas Söderlund wrote:
>> Describe THS/CIVM in the R8A77980 device trees.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
>>
>> ---
>> This patch is against the 'renesas-devel-20181008-v4.19-rc7' tag of Simon
>> Horman's 'renesas.git' repo.
>>
>> The thermal driver/bindings patches have been just posted...
>>
>> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 38
>> ++++++++++++++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -330,6 +330,19 @@
>> #power-domain-cells = <1>;
>> };
>>
>> + thermal: thermal@e6198000 {
>
> As Simon points out other Gen3 thermal nodes use "tsc:" not "thermal:".
Ah, indeed. However the manual calls this device THS/CIVM regardless of
the version.
>> + compatible = "renesas,r8a77980-thermal";
>> + reg = <0 0xe6198000 0 0x100>,
>> + <0 0xe61a0000 0 0x100>;
>> + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 522>;
>> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>> + resets = <&cpg 522>;
>> + #thermal-sensor-cells = <1>;
>
> Missing status = "okay" or am I missing something?
Yes, 'status = "okay"' can be omitted with the same effect.
>> + };
>> +
>> intc_ex: interrupt-controller@e61c0000 {
>> compatible = "renesas,intc-ex-r8a77980", "renesas,irqc";
>> #interrupt-cells = <2>;
>> @@ -1404,6 +1417,31 @@
>> };
>> };
>>
>> + thermal-zones {
>> + cpu-thermal {
>> + polling-delay-passive = <250>;
>> + polling-delay = <1000>;
>> + thermal-sensors = <&thermal 0>;
>> +
>> + trips {
>> + cpu-crit {
>> + temperature = <120000>;
>> + hysteresis = <2000>;
>> + type = "critical";
>> + };
>> + };
>> +
>> + cooling-maps {
>> + };
>> + };
>> +
>> + sensor2-thermal {
>> + polling-delay-passive = <250>;
>> + polling-delay = <1000>;
>> + thermal-sensors = <&thermal 1>;
>> + };
>> + };
>
> The thermal-zones node uses the Gen2 labels
I don't see it using any labels at all...
> and I think this should be
> updated to be as consistent as possible with other Gen3 users. For extra
OK, I forgot to look at the thermal zones on R8A779{5|6}0...
> points expand this could be expanded to also include the cooling-maps
> but could also happen in a separate patch if cooling-devices are not yet
> defined :-)
I'll look into that...
[...]
MBR, Sergei
