Hi Marek, On Sun, Dec 2, 2018 at 8:36 PM Marek Vasut <marek.va...@gmail.com> wrote: > It is possible that the PCA953x is powered down during suspend. > Use regmap cache to assure the registers in the PCA953x are in > line with the driver state after resume. > > Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com>
> +static int pca953x_suspend(struct device *dev) > +{ > + struct pca953x_chip *chip = dev_get_drvdata(dev); > + > + regcache_mark_dirty(chip->regmap); > + pca953x_regcache_sync(dev); > + regcache_cache_only(chip->regmap, true); Based on the discussion about adding suspend/resume support to the VC5 clock driver, I guess the two sync calls above are not needed here? > + > + regulator_disable(chip->regulator); > + > + return 0; > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds