Hi Geert, Thanks for your patch.
On 2019-03-01 10:38:31 +0100, Geert Uytterhoeven wrote: > devm_ioremap_resource() already prints an error message on failure, so > there is no need to repeat that. > > Signed-off-by: Geert Uytterhoeven <[email protected]> Reviewed-by: Niklas Söderlund <[email protected]> > --- > v2: > - Drop assignment to ret. > --- > drivers/media/platform/rcar_drif.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/rcar_drif.c > b/drivers/media/platform/rcar_drif.c > index c417ff8f6fe548f3..608e5217ccd50a1b 100644 > --- a/drivers/media/platform/rcar_drif.c > +++ b/drivers/media/platform/rcar_drif.c > @@ -1405,11 +1405,9 @@ static int rcar_drif_probe(struct platform_device > *pdev) > /* Register map */ > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > ch->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(ch->base)) { > - ret = PTR_ERR(ch->base); > - dev_err(&pdev->dev, "ioremap failed (%d)\n", ret); > - return ret; > - } > + if (IS_ERR(ch->base)) > + return PTR_ERR(ch->base); > + > ch->start = res->start; > platform_set_drvdata(pdev, ch); > > -- > 2.17.1 > -- Regards, Niklas Söderlund
