No need to check a retval after we assigned a constant to it. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/media/dvb-frontends/mn88473.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/mn88473.c b/drivers/media/dvb-frontends/mn88473.c index 08118b38533b..d1b11909825c 100644 --- a/drivers/media/dvb-frontends/mn88473.c +++ b/drivers/media/dvb-frontends/mn88473.c @@ -661,8 +661,7 @@ static int mn88473_probe(struct i2c_client *client, if (dev->client[1] == NULL) { ret = -ENODEV; dev_err(&client->dev, "I2C registration failed\n"); - if (ret) - goto err_regmap_0_regmap_exit; + goto err_regmap_0_regmap_exit; } dev->regmap[1] = regmap_init_i2c(dev->client[1], ®map_config); if (IS_ERR(dev->regmap[1])) { @@ -675,8 +674,7 @@ static int mn88473_probe(struct i2c_client *client, if (dev->client[2] == NULL) { ret = -ENODEV; dev_err(&client->dev, "2nd I2C registration failed\n"); - if (ret) - goto err_regmap_1_regmap_exit; + goto err_regmap_1_regmap_exit; } dev->regmap[2] = regmap_init_i2c(dev->client[2], ®map_config); if (IS_ERR(dev->regmap[2])) { -- 2.20.1