Hello!

On 29.04.2019 18:20, Geert Uytterhoeven wrote:

There is no need to print a message if devm_kzalloc() or

   Just kzalloc() in this case.

ioremap_nocache() fails, as the memory allocation core already takes
care of that.

Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
---
  drivers/irqchip/irq-renesas-irqc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-renesas-irqc.c 
b/drivers/irqchip/irq-renesas-irqc.c
index 438a063c76156d98..0955ffe12b32eb36 100644
--- a/drivers/irqchip/irq-renesas-irqc.c
+++ b/drivers/irqchip/irq-renesas-irqc.c
@@ -133,7 +133,6 @@ static int irqc_probe(struct platform_device *pdev)
p = kzalloc(sizeof(*p), GFP_KERNEL);
        if (!p) {
-               dev_err(&pdev->dev, "failed to allocate driver data\n");
                ret = -ENOMEM;
                goto err0;
        }
@@ -173,7 +172,6 @@ static int irqc_probe(struct platform_device *pdev)
        /* ioremap IOMEM and setup read/write callbacks */
        p->iomem = ioremap_nocache(io->start, resource_size(io));
        if (!p->iomem) {
-               dev_err(&pdev->dev, "failed to remap IOMEM\n");
                ret = -ENXIO;

   -ENOMEM?

[...]

MBR, Sergei

Reply via email to