Hello,
On Wednesday, November 18, 2009 11:06 PM Ben Dooks wrote:
> On Wed, Nov 18, 2009 at 02:33:09PM +0100, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.p...@samsung.com>
> >
> > Samsung S5PC110 SoC are newer Samsung SoCs. Like S5PC100 they are based
> > on CortexA8 ARM CPU, but have much more powerfull integrated periperals.
> > This patch adds gpiolib support for S5PC110 sub-platform.
>
> Hmm, another file with Byungho Min <bh...@samsung.com> in and no signoff
> from this person.
Ok, we will handle this better next time.
> [...]
> > diff --git a/arch/arm/plat-s5pc1xx/gpiolib.c
> > b/arch/arm/plat-s5pc1xx/gpiolib.c
> > index 60bf31d..2cd095c 100644
> > --- a/arch/arm/plat-s5pc1xx/gpiolib.c
> > +++ b/arch/arm/plat-s5pc1xx/gpiolib.c
> > @@ -453,6 +453,272 @@ static struct s3c_gpio_chip s5pc100_gpio_chips[] = {
> > #define s5pc1xx_gpio_chips s5pc100_gpio_chips
> >
> > #endif
> > +
> > +#ifdef CONFIG_CPU_S5PC110
>
> this amount of #ifdef screams seperate file.
>
> [...]
> > + }, {
> > + .base = S5PC110_MP0_5_BASE,
> > + .config = &gpio_cfg,
> > + .chip = {
> > + .base = S5PC110_MP0_5(0),
> > + .ngpio = S5PC110_GPIO_MP0_5_NR,
> > + .label = "MP0_5",
> > + },
> > + },
> > +};
> > +
> > +#define s5pc1xx_gpio_chips s5pc110_gpio_chips
> > +
> > +#endif
> > +
> > /* FIXME move from irq-gpio.c */
> > extern struct irq_chip s5pc1xx_gpioint;
> > extern void s5pc1xx_irq_gpioint_handler(unsigned int irq, struct irq_desc
> > *desc);
> > diff --git a/arch/arm/plat-s5pc1xx/irq-gpio.c
> > b/arch/arm/plat-s5pc1xx/irq-gpio.c
> > index f5d8dab..b13308f 100644
> > --- a/arch/arm/plat-s5pc1xx/irq-gpio.c
> > +++ b/arch/arm/plat-s5pc1xx/irq-gpio.c
> > @@ -142,6 +142,116 @@ static int s5pc100_group_end = 21;
> >
> > #endif
> >
> > +#ifdef CONFIG_CPU_S5PC110
>
> these follwing functions could have had their info added to an extended
> gpio structure, say struct s5p_gpio_chip and had a s3c_gpio_chip embededded in
> it, which would make the code simpler,
>
> ie:
>
> struct s5p_gpio_chip {
> struct s3c_gpio_chip chip;
> unsigned int gpio_start;
> unsigned int gpio_groupl
> };
>
> and then you could have gone chip->info easily.
Thanks for suggestion! I will rewrite this and split gpio lib support into
separate files for each sub-platform and send new patches soon.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
