Sylwester Nawrocki wrote:
> 
> FIMC device is a camera interface embedded in S3C/S5P Samsung SOC series.
> It supports ITU-R BT.601/656 and MIPI-CSI2 standards, memory to memory
> operations, color conversion, resizing and rotation.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
> ---
>  arch/arm/plat-samsung/include/plat/fimc.h      |   31 ++
>  arch/arm/plat-samsung/include/plat/regs-fimc.h |  361
> ++++++++++++++++++++++++
>  2 files changed, 392 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/plat-samsung/include/plat/fimc.h
>  create mode 100644 arch/arm/plat-samsung/include/plat/regs-fimc.h
> 
> diff --git a/arch/arm/plat-samsung/include/plat/fimc.h b/arch/arm/plat-
> samsung/include/plat/fimc.h
> new file mode 100644
> index 0000000..be1e853
> --- /dev/null
> +++ b/arch/arm/plat-samsung/include/plat/fimc.h
> @@ -0,0 +1,31 @@
> +/* linux/arch/arm/plat-samsung/include/plat/fimc.h
> + *
> + * Platform header file for FIMC driver
> + *
> + * Copyright (c) 2010 Samsung Electronics
> + *
> + * Sylwester Nawrocki, <s.nawro...@samsung.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef FIMC_H_
> +#define FIMC_H_
> +
> +#include <linux/device.h>
> +#include <linux/platform_device.h>
> +
> +

2 empty lines...

> +#define FIMC_MAX_FIFO_TARGETS        1
> +#define FIMC_LCD_FIFO_TARGET 0
> +
> +struct s3c_fifo_link;
> +
> +struct samsung_plat_fimc {
> +     struct s3c_fifo_link    *fifo_targets[FIMC_MAX_FIFO_TARGETS];
> +};
> +
> +#endif /* FIMC_H_ */
> +

No need last empty line...

> diff --git a/arch/arm/plat-samsung/include/plat/regs-fimc.h
b/arch/arm/plat-
> samsung/include/plat/regs-fimc.h
> new file mode 100644
> index 0000000..6946a93
> --- /dev/null
> +++ b/arch/arm/plat-samsung/include/plat/regs-fimc.h
> @@ -0,0 +1,361 @@
> +/* arch/arm/plat-s5p/include/plat/regs-fimc.h
> + *
> + * Register definition file for Samsung Camera Interface (FIMC) driver
> + *
> + * Copyright (c) 2010 Samsung Electronics
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef REGS_FIMC_H_
> +#define REGS_FIMC_H_
> +
> +#define S5P_CIOYSA(__x)                              (0x18 + (__x) * 4)
> +#define S5P_CIOCBSA(__x)                     (0x28 + (__x) * 4)
> +#define S5P_CIOCRSA(__x)                     (0x38 + (__x) * 4)
> +
> +/* Input source format */
> +#define S5P_CISRCFMT                         0x00
> +/* Window offset */
> +#define S5P_CIWDOFST                         0x04
> +/* Global control */
> +#define S5P_CIGCTRL                          0x08
> +/* Window offset 2 */
> +#define S5P_CIWDOFST2                                0x14
> +/* Output DMA Y 1st frame start address */
> +#define S5P_CIOYSA1                          0x18
> +/* Output DMA Y 2nd frame start address */
> +#define S5P_CIOYSA2                          0x1c
> +/* Output DMA Y 3rd frame start address */
> +#define S5P_CIOYSA3                          0x20
> +/* Output DMA Y 4th frame start address */
> +#define S5P_CIOYSA4                          0x24
> +/* Output DMA Cb 1st frame start address */
> +#define S5P_CIOCBSA1                         0x28
> +/* Output DMA Cb 2nd frame start address */
> +#define S5P_CIOCBSA2                         0x2c
> +/* Output DMA Cb 3rd frame start address */
> +#define S5P_CIOCBSA3                         0x30
> +/* Output DMA Cb 4th frame start address */
> +#define S5P_CIOCBSA4                         0x34
> +/* Output DMA Cr 1st frame start address */
> +#define S5P_CIOCRSA1                         0x38
> +/* Output DMA Cr 2nd frame start address */
> +#define S5P_CIOCRSA2                         0x3c
> +/* Output DMA Cr 3rd frame start address */
> +#define S5P_CIOCRSA3                         0x40
> +/* Output DMA Cr 4th frame start address */
> +#define S5P_CIOCRSA4                         0x44
> +/* Target image format */
> +#define S5P_CITRGFMT                         0x48
> +/* Output DMA control */
> +#define S5P_CIOCTRL                          0x4c
> +/* Pre-scaler control 1 */
> +#define S5P_CISCPRERATIO                     0x50
> +/* Pre-scaler control 2 */
> +#define S5P_CISCPREDST                               0x54
> +/* Main scaler control */
> +#define S5P_CISCCTRL                         0x58
> +/* Target area */
> +#define S5P_CITAREA                          0x5c
> +/* Status */
> +#define S5P_CISTATUS                         0x64
> +/* Image capture enable command */
> +#define S5P_CIIMGCPT                         0xc0
> +/* Capture sequence */
> +#define S5P_CICPTSEQ                         0xc4
> +/* Image effects */
> +#define S5P_CIIMGEFF                         0xd0
> +/* Y frame start address for input DMA */
> +#define S5P_CIIYSA0                          0xd4
> +/* Cb frame start address for input DMA */
> +#define S5P_CIICBSA0                         0xd8
> +/* Cr frame start address for input DMA */
> +#define S5P_CIICRSA0                         0xdc
> +/* Real input DMA image size */
> +#define S5P_CIREAL_ISIZE                     0xf8
> +/* Input DMA control */
> +#define S5P_MSCTRL                           0xfc
> +/* Y frame start address for input DMA */
> +#define S5P_CIIYSA1                          0x144
> +/* Cb frame start address for input DMA */
> +#define S5P_CIICBSA1                         0x148
> +/* Cr frame start address for input DMA */
> +#define S5P_CIICRSA1                         0x14c
> +/* Output DMA Y offset */
> +#define S5P_CIOYOFF                          0x168
> +/* Output DMA CB offset */
> +#define S5P_CIOCBOFF                         0x16c
> +/* Output DMA CR offset */
> +#define S5P_CIOCROFF                         0x170
> +/* Input DMA Y offset */
> +#define S5P_CIIYOFF                          0x174
> +/* Input DMA CB offset */
> +#define S5P_CIICBOFF                         0x178
> +/* Input DMA CR offset */
> +#define S5P_CIICROFF                         0x17c
> +/* Input DMA original image size */
> +#define S5P_ORGISIZE                         0x180
> +/* Output DMA original image size */
> +#define S5P_ORGOSIZE                         0x184
> +/* Real output DMA image size */
> +#define S5P_CIEXTEN                          0x188
> +/* DMA parameter */
> +#define S5P_CIDMAPARAM                               0x18c
> +/* MIPI CSI image format */
> +#define S5P_CSIIMGFMT                                0x194
> +
> +

2 empty lines?

> +#define S5P_CISRCFMT_SOURCEHSIZE(x)          ((x) << 16)
> +#define S5P_CISRCFMT_SOURCEVSIZE(x)          ((x) << 0)
> +
> +#define S5P_CIWDOFST_WINHOROFST(x)           ((x) << 16)
> +#define S5P_CIWDOFST_WINVEROFST(x)           ((x) << 0)
> +
> +#define S5P_CIWDOFST2_WINHOROFST2(x)         ((x) << 16)
> +#define S5P_CIWDOFST2_WINVEROFST2(x)         ((x) << 0)
> +
> +#define S5P_CITRGFMT_TARGETHSIZE(x)          ((x) << 16)
> +#define S5P_CITRGFMT_TARGETVSIZE(x)          ((x) << 0)
> +
> +#define S5P_CISCPRERATIO_SHFACTOR(x)         ((x) << 28)
> +#define S5P_CISCPRERATIO_PREHORRATIO(x)              ((x) << 16)
> +#define S5P_CISCPRERATIO_PREVERRATIO(x)              ((x) << 0)
> +
> +#define S5P_CISCPREDST_PREDSTWIDTH(x)                ((x) << 16)
> +#define S5P_CISCPREDST_PREDSTHEIGHT(x)               ((x) << 0)
> +
> +#define S5P_CISCCTRL_MAINHORRATIO(x)         ((x) << 16)
> +#define S5P_CISCCTRL_MAINVERRATIO(x)         ((x) << 0)
> +
> +#define S5P_CITAREA_TARGET_AREA(x)           ((x) << 0)
> +
> +#define S5P_CIIMGEFF_PAT_CB(x)                       ((x) << 13)
> +#define S5P_CIIMGEFF_PAT_CR(x)                       ((x) << 0)
> +
> +#define S5P_CIREAL_ISIZE_HEIGHT(x)           ((x) << 16)
> +#define S5P_CIREAL_ISIZE_WIDTH(x)            ((x) << 0)
> +
> +#define S5P_MSCTRL_SUCCESSIVE_COUNT(x)               ((x) << 24)
> +
> +#define S5P_CIOYOFF_VERTICAL(x)                      ((x) << 16)
> +#define S5P_CIOYOFF_HORIZONTAL(x)            ((x) << 0)
> +
> +#define S5P_CIOCBOFF_VERTICAL(x)             ((x) << 16)
> +#define S5P_CIOCBOFF_HORIZONTAL(x)           ((x) << 0)
> +
> +#define S5P_CIOCROFF_VERTICAL(x)             ((x) << 16)
> +#define S5P_CIOCROFF_HORIZONTAL(x)           ((x) << 0)
> +
> +#define S5P_CIIYOFF_VERTICAL(x)                      ((x) << 16)
> +#define S5P_CIIYOFF_HORIZONTAL(x)            ((x) << 0)
> +
> +#define S5P_CIICBOFF_VERTICAL(x)             ((x) << 16)
> +#define S5P_CIICBOFF_HORIZONTAL(x)           ((x) << 0)
> +
> +#define S5P_CIICROFF_VERTICAL(x)             ((x) << 16)
> +#define S5P_CIICROFF_HORIZONTAL(x)           ((x) << 0)
> +
> +#define S5P_ORGISIZE_VERTICAL(x)             ((x) << 16)
> +#define S5P_ORGISIZE_HORIZONTAL(x)           ((x) << 0)
> +
> +#define S5P_ORGOSIZE_VERTICAL(x)             ((x) << 16)
> +#define S5P_ORGOSIZE_HORIZONTAL(x)           ((x) << 0)
> +
> +

Same...2 empty lines...

And above definitions used same bit shift...((x) << 16) or ((x) << 0)...
Hmm...I'm thinking...whether there is any method to reduce similar codes...

> +/* Register's bit definitions */
> +
> +/* Source format register */
> +#define S5P_CISRCFMT_ITU601_8BIT             (1 << 31)
> +#define S5P_CISRCFMT_ITU656_8BIT             (0 << 31)
> +#define S5P_CISRCFMT_ITU601_16BIT            (1 << 29)
> +#define S5P_CISRCFMT_ORDER422_YCBYCR         (0 << 14)
> +#define S5P_CISRCFMT_ORDER422_YCRYCB         (1 << 14)
> +#define S5P_CISRCFMT_ORDER422_CBYCRY         (2 << 14)
> +#define S5P_CISRCFMT_ORDER422_CRYCBY         (3 << 14)
> +/* ITU601 16bit only */
> +#define S5P_CISRCFMT_ORDER422_Y4CBCRCBCR     (0 << 14)
> +/* ITU601 16bit only */

Same comments... ITU601 16bit only...

> +#define S5P_CISRCFMT_ORDER422_Y4CRCBCRCB     (1 << 14)
> +
> +/* Window offset register */
> +#define S5P_CIWDOFST_WINOFSEN                        (1 << 31)
> +#define S5P_CIWDOFST_CLROVFIY                        (1 << 30)
> +#define S5P_CIWDOFST_CLROVRLB                        (1 << 29)
> +#define S5P_CIWDOFST_WINHOROFST_MASK         (0x7ff << 16)
> +#define S5P_CIWDOFST_CLROVFICB                       (1 << 15)
> +#define S5P_CIWDOFST_CLROVFICR                       (1 << 14)
> +#define S5P_CIWDOFST_WINVEROFST_MASK         (0xfff << 0)
> +
> +/* Global control register */
> +#define S5P_CIGCTRL_SWRST                    (1 << 31)
> +#define S5P_CIGCTRL_CAMRST_A                 (1 << 30)
> +#define S5P_CIGCTRL_SELCAM_ITU_B             (0 << 29)
> +#define S5P_CIGCTRL_SELCAM_ITU_A             (1 << 29)
> +#define S5P_CIGCTRL_SELCAM_ITU_MASK          (1 << 29)
> +#define S5P_CIGCTRL_TESTPAT_NORMAL           (0 << 27)
> +#define S5P_CIGCTRL_TESTPAT_COLOR_BAR                (1 << 27)
> +#define S5P_CIGCTRL_TESTPAT_HOR_INC          (2 << 27)
> +#define S5P_CIGCTRL_TESTPAT_VER_INC          (3 << 27)
> +#define S5P_CIGCTRL_TESTPAT_MASK             (3 << 27)
> +#define S5P_CIGCTRL_TESTPAT_SHIFT            (27)
> +#define S5P_CIGCTRL_INVPOLPCLK                       (1 << 26)
> +#define S5P_CIGCTRL_INVPOLVSYNC                      (1 << 25)
> +#define S5P_CIGCTRL_INVPOLHREF                       (1 << 24)
> +#define S5P_CIGCTRL_IRQ_OVFEN                        (1 << 22)
> +#define S5P_CIGCTRL_HREF_MASK                        (1 << 21)
> +#define S5P_CIGCTRL_IRQ_EDGE                 (0 << 20)
> +#define S5P_CIGCTRL_IRQ_LEVEL                        (1 << 20)
> +#define S5P_CIGCTRL_IRQ_CLR                  (1 << 19)
> +#define S5P_CIGCTRL_IRQ_DISABLE                      (0 << 16)
> +#define S5P_CIGCTRL_IRQ_ENABLE                       (1 << 16)
> +#define S5P_CIGCTRL_SHDW_DISABLE             (1 << 12)
> +#define S5P_CIGCTRL_SELCAM_MIPI_B            (0 << 7)
> +#define S5P_CIGCTRL_SELCAM_MIPI_A            (1 << 7)
> +#define S5P_CIGCTRL_SELCAM_MIPI_MASK         (1 << 7)
> +#define S5P_CIGCTRL_CAMIF_SELWB                      (1 << 6)
> +#define S5P_CIGCTRL_INVPOLHSYNC                      (1 << 4)
> +#define S5P_CIGCTRL_SELCAM_ITU                       (0 << 3)
> +#define S5P_CIGCTRL_SELCAM_MIPI                      (1 << 3)
> +#define S5P_CIGCTRL_PROGRESSIVE                      (0 << 0)
> +#define S5P_CIGCTRL_INTERLACE                        (1 << 0)
> +
> +/* Window offset2 register */
> +#define S5P_CIWDOFST_WINHOROFST2_MASK                (0xfff << 16)
> +#define S5P_CIWDOFST_WINVEROFST2_MASK                (0xfff << 16)
> +
> +/* Target format register */
> +#define S5P_CITRGFMT_INROT90                 (1 << 31)
> +#define S5P_CITRGFMT_OUTFORMAT_YCBCR420              (0 << 29)
> +#define S5P_CITRGFMT_OUTFORMAT_YCBCR422              (1 << 29)
> +#define S5P_CITRGFMT_OUTFORMAT_YCBCR422_1PLANE       (2 << 29)
> +#define S5P_CITRGFMT_OUTFORMAT_RGB           (3 << 29)
> +#define S5P_CITRGFMT_OUT_FMT_MASK            (3 << 29)
> +#define S5P_CITRGFMT_HSIZE_MASK                      (0xfff << 16)
> +#define S5P_CITRGFMT_FLIP_SHIFT                      (14)
> +#define S5P_CITRGFMT_FLIP_NORMAL             (0 << 14)
> +#define S5P_CITRGFMT_FLIP_X_MIRROR           (1 << 14)
> +#define S5P_CITRGFMT_FLIP_Y_MIRROR           (2 << 14)
> +#define S5P_CITRGFMT_FLIP_180                        (3 << 14)
> +#define S5P_CITRGFMT_FLIP_MASK                       (3 << 14)
> +#define S5P_CITRGFMT_OUTROT90                        (1 << 13)
> +#define S5P_CITRGFMT_VSIZE_MASK                      (0xfff << 0)
> +
> +/* Output DMA control register */
> +#define S5P_CIOCTRL_ORDER422_MASK            (3 << 0)
> +#define S5P_CIOCTRL_ORDER422_CRYCBY          (0 << 0)
> +#define S5P_CIOCTRL_ORDER422_YCRYCB          (1 << 0)
> +#define S5P_CIOCTRL_ORDER422_CBYCRY          (2 << 0)
> +#define S5P_CIOCTRL_ORDER422_YCBYCR          (3 << 0)
> +#define S5P_CIOCTRL_LASTIRQ_ENABLE           (1 << 2)
> +#define S5P_CIOCTRL_YCBCR_3PLANE             (0 << 3)
> +#define S5P_CIOCTRL_YCBCR_2PLANE             (1 << 3)
> +#define S5P_CIOCTRL_YCBCR_PLANE_MASK         (1 << 3)
> +#define S5P_CIOCTRL_ORDER2P_SHIFT            (24)
> +#define S5P_CIOCTRL_ORDER2P_MASK             (3 << 24)
> +#define S5P_CIOCTRL_ORDER422_2P_LSB_CRCB     (0 << 24)
> +
> +

2 empty lines...

> +/* Main scaler control register */
> +#define S5P_CISCCTRL_SCALERBYPASS            (1 << 31)
> +#define S5P_CISCCTRL_SCALEUP_H                       (1 << 30)
> +#define S5P_CISCCTRL_SCALEUP_V                       (1 << 29)
> +#define S5P_CISCCTRL_CSCR2Y_NARROW           (0 << 28)
> +#define S5P_CISCCTRL_CSCR2Y_WIDE             (1 << 28)
> +#define S5P_CISCCTRL_CSCY2R_NARROW           (0 << 27)
> +#define S5P_CISCCTRL_CSCY2R_WIDE             (1 << 27)
> +#define S5P_CISCCTRL_LCDPATHEN_FIFO          (1 << 26)
> +#define S5P_CISCCTRL_PROGRESSIVE             (0 << 25)
> +#define S5P_CISCCTRL_INTERLACE                       (1 << 25)
> +#define S5P_CISCCTRL_SCALERSTART             (1 << 15)
> +#define S5P_CISCCTRL_INRGB_FMT_RGB565                (0 << 13)
> +#define S5P_CISCCTRL_INRGB_FMT_RGB666                (1 << 13)
> +#define S5P_CISCCTRL_INRGB_FMT_RGB888                (2 << 13)
> +#define S5P_CISCCTRL_INRGB_FMT_MASK          (3 << 13)
> +#define S5P_CISCCTRL_OUTRGB_FMT_RGB565               (0 << 11)
> +#define S5P_CISCCTRL_OUTRGB_FMT_RGB666               (1 << 11)
> +#define S5P_CISCCTRL_OUTRGB_FMT_RGB888               (2 << 11)
> +#define S5P_CISCCTRL_OUTRGB_FMT_MASK         (3 << 11)
> +#define S5P_CISCCTRL_EXTRGB_NORMAL           (0 << 10)
> +#define S5P_CISCCTRL_EXTRGB_EXTENSION                (1 << 10)
> +#define S5P_CISCCTRL_ONE2ONE                 (1 << 9)
> +
> +/* Status register */
> +#define S5P_CISTATUS_OVFIY                   (1 << 31)
> +#define S5P_CISTATUS_OVFICB                  (1 << 30)
> +#define S5P_CISTATUS_OVFICR                  (1 << 29)
> +#define S5P_CISTATUS_VSYNC                   (1 << 28)
> +#define S5P_CISTATUS_WINOFSTEN                       (1 << 25)
> +#define S5P_CISTATUS_IMGCPTEN                        (1 << 22)
> +#define S5P_CISTATUS_IMGCPTENSC                      (1 << 21)
> +#define S5P_CISTATUS_VSYNC_A                 (1 << 20)
> +#define S5P_CISTATUS_VSYNC_B                 (1 << 19)
> +#define S5P_CISTATUS_OVRLB                   (1 << 18)
> +#define S5P_CISTATUS_FRAMEEND                        (1 << 17)
> +#define S5P_CISTATUS_LASTCAPTUREEND          (1 << 16)
> +#define S5P_CISTATUS_VVALID_A                        (1 << 15)
> +#define S5P_CISTATUS_VVALID_B                        (1 << 14)
> +
> +/* Image capture enable register */
> +#define S5P_CIIMGCPT_IMGCPTEN                        (1 << 31)
> +#define S5P_CIIMGCPT_IMGCPTEN_SC             (1 << 30)
> +#define S5P_CIIMGCPT_CPT_FREN_ENABLE         (1 << 25)
> +#define S5P_CIIMGCPT_CPT_FRMOD_EN            (0 << 18)
> +#define S5P_CIIMGCPT_CPT_FRMOD_CNT           (1 << 18)
> +
> +/* Image effects register */
> +#define S5P_CIIMGEFF_IE_DISABLE                      (0 << 30)
> +#define S5P_CIIMGEFF_IE_ENABLE                       (1 << 30)
> +#define S5P_CIIMGEFF_IE_SC_BEFORE            (0 << 29)
> +#define S5P_CIIMGEFF_IE_SC_AFTER             (1 << 29)
> +#define S5P_CIIMGEFF_FIN_BYPASS                      (0 << 26)
> +#define S5P_CIIMGEFF_FIN_ARBITRARY           (1 << 26)
> +#define S5P_CIIMGEFF_FIN_NEGATIVE            (2 << 26)
> +#define S5P_CIIMGEFF_FIN_ARTFREEZE           (3 << 26)
> +#define S5P_CIIMGEFF_FIN_EMBOSSING           (4 << 26)
> +#define S5P_CIIMGEFF_FIN_SILHOUETTE          (5 << 26)
> +#define S5P_CIIMGEFF_FIN_MASK                        (7 << 26)
> +#define S5P_CIIMGEFF_PAT_CBCR_MASK           ((0xff < 13) | (0xff <
> 0))
> +
> +/* Real input DMA size register */
> +#define S5P_CIREAL_ISIZE_AUTOLOAD_ENABLE     (1 << 31)
> +#define S5P_CIREAL_ISIZE_ADDR_CH_DISABLE     (1 << 30)
> +
> +/* Input DMA control register */
> +#define S5P_MSCTRL_IN_BURST_COUNT_MASK               (3 << 24)
> +#define S5P_MSCTRL_2P_IN_ORDER_MASK          (3 << 16)
> +#define S5P_MSCTRL_2P_IN_ORDER_SHIFT         (16)
> +#define S5P_MSCTRL_C_INT_IN_3PLANE           (0 << 15)
> +#define S5P_MSCTRL_C_INT_IN_2PLANE           (1 << 15)
> +#define S5P_MSCTRL_C_INT_IN_MASK             (1 << 15)
> +#define S5P_MSCTRL_FLIP_SHIFT                        (13)
> +#define S5P_MSCTRL_FLIP_MASK                 (3 << 13)
> +#define S5P_MSCTRL_FLIP_NORMAL                       (0 << 13)
> +#define S5P_MSCTRL_FLIP_X_MIRROR             (1 << 13)
> +#define S5P_MSCTRL_FLIP_Y_MIRROR             (2 << 13)
> +#define S5P_MSCTRL_FLIP_180                  (3 << 13)
> +#define S5P_MSCTRL_ORDER422_SHIFT            (4)
> +#define S5P_MSCTRL_ORDER422_CRYCBY           (0 << 4)
> +#define S5P_MSCTRL_ORDER422_YCRYCB           (1 << 4)
> +#define S5P_MSCTRL_ORDER422_CBYCRY           (2 << 4)
> +#define S5P_MSCTRL_ORDER422_YCBYCR           (3 << 4)
> +#define S5P_MSCTRL_ORDER422_MASK             (3 << 4)
> +#define S5P_MSCTRL_INPUT_EXTCAM                      (0 << 3)
> +#define S5P_MSCTRL_INPUT_MEMORY                      (1 << 3)
> +#define S5P_MSCTRL_INPUT_MASK                        (1 << 3)
> +#define S5P_MSCTRL_INFORMAT_YCBCR420         (0 << 1)
> +#define S5P_MSCTRL_INFORMAT_YCBCR422         (1 << 1)
> +#define S5P_MSCTRL_INFORMAT_YCBCR422_1PLANE  (2 << 1)
> +#define S5P_MSCTRL_INFORMAT_RGB                      (3 << 1)
> +#define S5P_MSCTRL_INFORMAT_MASK             (3 << 1)
> +#define S5P_MSCTRL_ENVID                     (1 << 0)
> +
> +/* DMA parameter register */
> +#define S5P_CIDMAPARAM_R_MODE_64X32          (3 << 29)
> +#define S5P_CIDMAPARAM_W_MODE_LINEAR         (0 << 13)
> +#define S5P_CIDMAPARAM_W_MODE_CONFTILE               (1 << 13)
> +#define S5P_CIDMAPARAM_W_MODE_64X32          (3 << 13)
> +
> +#endif /* REGS_FIMC_H_ */
> --
I wonder...we really need above every definitions?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene....@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to