В сообщении от 24 августа 2010 17:41:57 автор Marek Vasut написал: > Dne Út 24. srpna 2010 16:21:01 Vasily Khoruzhick napsal(a): > > В сообщении от 24 августа 2010 17:01:12 автор Marek Vasut написал: > > > pr_err() and don't probe the device for which you couldn't request > > > GPIO. > > > > Well, handling those errors in machine init functions doesn't make sense. > > PDA is not usable without basic hardware. > > You can use PDA without LCD for example (there are such people, trust me). > So, this comment really isn't too valid. You can also use PDA without MMC > support, you still have onboard flash, etc. etc.
But error handling here just increases code size, and gpio_request in init function should always succeed. It means something's going really wrong (kernel bug or misconfiguration) if gpio_request fails. Btw, Ben suggested to use WARN_ON in machine init, look through init functions of qt2410, n30, rx1950, vr1000, etc. Regards Vasily
signature.asc
Description: This is a digitally signed message part.
