On Tue, Jan 31, 2012 at 10:40:43PM +0000, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: > > From: Sangsu Park <sangsu4u.p...@samsung.com> > > > > This patch adds follwing. > > - IO-map for EXYNOS5250 GPIO support > > - EXYNOS5250 GPIO bank size/number definitions > > - memory map definition for S5P GPIO4 > > > > Signed-off-by: Sangsu Park <sangsu4u.p...@samsung.com> > > Signed-off-by: Kukjin Kim <kgene....@samsung.com> > > Do you actually need these static mapping definitions? The samsung > gpiolib initialization is called from a core_initcall(), and at this > time ioremap() is fully capable of working.
Indeed. Please get rid of the S5P_VA_GPIO* macros and use ioremap to set up the registers mappings. I understand that the existing code already does that, but I don't want to see any more added. Also, it is easy to fix by adding the ioremap calls to samsung_gpio_init() g. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
