On 12 March 2012 19:51, Mark Brown <broo...@opensource.wolfsonmicro.com> wrote: > On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote: >> The platform specific callback to setup the sdhci pin mux and pin config >> is removed and the pinctrl subsystem interface is used to setup the >> mux and config. > > You've only added pinctrl support for Exynos but this driver is also > used by SoCs going back to s3c24xx era. Either all those SoCs need to > be converted to use pinctrl or the driver needs to understand both > methods (eg, using pinctrl if no callback is supplied).
Yes, I agree with your comment. I did refer to manuals of s3c24xx to Exynos to ensure that the samsung pinctrl driver is generic and reusable on all samsung soc's. I hope I have not missed out something important that would require additional tweaks in the samsung pinctrl driver. The missing bits now are gpio interrupt and wakeup interrupt support in the samsung pinctrl driver. Once that is complete, I believe it should be easy to add support for other SoC and convert the drivers to use pinctrl (other option being to let pinctrl driver hog all the mappings at boot and remove the cfg_gpio platform callbacks from the driver). Thank you Mark for your comments. Regards, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
