On Wed, May 9, 2012 at 3:34 AM, Thomas Abraham <thomas.abra...@linaro.org> wrote: > > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the slave select line, this callback can be removed from the > controller data and replaced with call to gpio_set_value in the driver. > This patch is ok. Separately, you might also want to see if we really need the air-tight protection of spin_lock_irqsave around enable_cs - IIRC someone had a CS coming out of an gpio extender connected over I2C -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
- Re: [PATCH 05/10] ARM: Samsung: Updat... Mark Brown
- Re: [PATCH 05/10] ARM: Samsung: U... Grant Likely
- [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_p... Thomas Abraham
- Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1... Mark Brown
- Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi... Heiko Stübner
- Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx... Mark Brown
- Re: [PATCH 06/10] ARM: Samsung: Modify s3c... Thomas Abraham
- Re: [PATCH 06/10] ARM: Samsung: Modif... Mark Brown
- Re: [PATCH 06/10] ARM: Samsung: M... Thomas Abraham
- [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback... Thomas Abraham
- Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level'... Jassi Brar
- Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level'... Heiko Stübner
- Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level'... Grant Likely
- [PATCH 08/10] ARM: Exynos4: Fix the incorrect hierarchy of ... Thomas Abraham
- [PATCH 09/10] ARM: Exynos5: Add spi clock support Thomas Abraham
- [PATCH 10/10] spi: s3c64xx: add device tree support Thomas Abraham
- Re: [PATCH 10/10] spi: s3c64xx: add device tree suppor... Mark Brown
- Re: [PATCH 10/10] spi: s3c64xx: add device tree su... Thomas Abraham
- Re: [PATCH 10/10] spi: s3c64xx: add device tre... Mark Brown
- Re: [PATCH 10/10] spi: s3c64xx: add device... Thomas Abraham