> From: Dinh Nguyen [mailto:dingu...@altera.com] > Sent: Tuesday, January 14, 2014 1:30 PM > > On Tue, 2014-01-14 at 13:14 -0800, Greg KH wrote: > > On Tue, Jan 14, 2014 at 08:57:12PM +0000, Paul Zimmerman wrote: > > > > From: Dinh Nguyen [mailto:dingu...@altera.com] > > > > Sent: Tuesday, January 14, 2014 12:46 PM > > > > > > > > On Tue, 2014-01-14 at 06:21 -0800, Greg KH wrote: > > > > > On Tue, Jan 14, 2014 at 05:01:00AM -0600, dingu...@altera.com wrote: > > > > > > From: Dinh Nguyen <dingu...@altera.com> > > > > > > > > > > > > Hi, > > > > > > > > > > > > I'm starting work downstream on combining the DWC2 host driver and > > > > > > the s3c-hsotg > > > > > > gadget driver into a dual-role OTG driver. Before I go further, I > > > > > > was hoping to > > > > > > solicit comments on whether or not my initial approach is correct? > > > > > > I know there > > > > > > are plans to combine the 2, so would like to solicit > > > > > > comments/suggestions so > > > > > > that I can also upstream it as well. > > > > > > > > > > > > These 2 patches: > > > > > > > > > > > > * Moves the DWC2 driver out of drivers/staging into > > > > > > drivers/usb/dwc2/ > > > > > > > > > > This already happened yesterday in my tree, so you should see this in > > > > > linux-next by now, no need to do it again :) > > > > > > > > > > > > > I see it now. Thanks for the pointer. > > > > > > > > > > * Moves the s3c-hsotg driver into drivers/usb/dwc2/ > > > > > > * Delete s3c-hsotg.h > > > > > > * Make the s3c-hsotg.c file use the defines in hw.h from the DWC2 > > > > > > driver. > > > > > > > > > > > > This initial patch has been tested on the SOCFPGA platform only in > > > > > > Host-only > > > > > > and Gadget-only mode. > > > > > > > > > > > > The next step would be to do the combining of the driver into a > > > > > > dual-role OTG > > > > > > driver. > > > > > > > > > > I was told that merging the two of these isn't going to work as the > > > > > silicon is just too different, which is why I allowed the code to move > > > > > out of staging. If you feel differently, and think you can combine > > > > > the > > > > > two drivers, that's wonderful, I'll gladly take patches to do so, but > > > > > be > > > > > sure to test on the proper platforms to make sure nothing breaks. > > > > > > > > > > > > > I wasn't aware of the silicon differences. I just took the s3c-hsotg > > > > driver as is and it worked fine on my version 2.93a of the USB IP. I'll > > > > search the ML for information, or perhaps Paul can comment? > > > > > > I think Greg is thinking of the octeon-usb driver in staging [1], not > > > the s3c-hsotg driver. The plan was always to eventually merge dwc2 with > > > s3c-hsotg. > > > > Yes, I'm totally confused, you are right. > > > > Nevermind then, Dinh, if you want to redo your patch after 3.14-rc1 is > > out, that would be great as merging the drivers together can be done > > easier after that development point. > > Unless, Paul has already started the work, I can take a crack at it.
No, I have not started any work on that (too busy with other things these days), so please feel free to work on it. -- Paul
