On Thu, 2014-03-13 at 05:53 -0700, Joe Perches wrote:
> Maybe this was supposed to be something like
> 
>       ns = p->tstamp_lo
>       ns |= ((u64)tstamp_hi) << 32;
> 
> If not, maybe it warrants a comment around
> here or on the descriptor definition
[]
> > +struct sxgbe_rx_ctxt_desc {
> > +   u32 tstamp_lo:32;
> > +   u32 tstamp_hi:32;

or maybe these would be better renamed like:

        u32 tstamp_nsecs;
        u32 tstamp_secs;

btw2: I still think using

        u32     foo:32;

is asking for gcc to generate bad code.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to