Hi Daniel,

On 08.04.2014 14:19, Daniel Lezcano wrote:
The code to initiate and exit the powerdown sequence is the same in pm.c and
cpuidle.c.

Let's split the common part in the pm.c and reuse it from the cpu_pm notifier.

That is one more step forward to make the cpuidle driver arch indenpendant.

Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org>
Reviewed-by: Viresh Kumar <viresh.ku...@linaro.org>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
---
  arch/arm/mach-exynos/cpuidle.c |   21 ---------------------
  arch/arm/mach-exynos/pm.c      |   22 ++++++++++++++++++----
  2 files changed, 18 insertions(+), 25 deletions(-)

[snip]

-static int exynos_pm_suspend(void)
+static void exynos_pm_central_suspend(void)
  {
        unsigned long tmp;

        /* Setting Central Sequence Register for power down mode */
-
        tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
        tmp &= ~S5P_CENTRAL_LOWPWR_CFG;
        __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
+}
+
+static int exynos_pm_suspend(void)
+{
+       unsigned long tmp;


Shouldn't exynos_pm_central_suspend() be called here in place of the code being moved to that function?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to