Hi Chanwoo,

On 16.04.2014 12:11, Chanwoo Choi wrote:
This patch add DT binding documentation for Exynos3250 ADC IP. Exynos3250 has
special clock ('sclk_tsadc') for ADC which provide clock to internal ADC.

Cc: Rob Herring <robh...@kernel.org>
Cc: Pawel Moll <pawel.m...@arm.com>
Cc: Mark Rutland <mark.rutl...@arm.com>
Cc: Ian Campbell <ijc+devicet...@hellion.org.uk>
Cc: Kumar Gala <ga...@codeaurora.org>
Cc: Randy Dunlap <rdun...@infradead.org>
Cc: Kukjin Kim <kgene....@samsung.com>
Cc: Naveen Krishna Chatradhi <ch.nav...@samsung.com>
Cc: Tomasz Figa <t.f...@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Kyungmin Park <kyungmin.p...@samsung.com>
---
  .../devicetree/bindings/arm/samsung/exynos-adc.txt   | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt 
b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
index 5d49f2b..7532ec3 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
@@ -14,6 +14,8 @@ Required properties:
                                for exynos4412/5250 controllers.
                        Must be "samsung,exynos-adc-v2" for
                                future controllers.
+                       Must be "samsung,exynos-adc-v3" for
+                               for exynos3250 controllers.

I don't think adc-v3 is correct here. It looks like a normal V2 with additional special clock input. Possibly "samsung,exynos3250-adc-v2" or "samsung,exynos-adc-v2-sclk" would be better choices.

  - reg:                        Contains ADC register address range (base 
address and
                        length) and the address of the phy enable register.
  - interrupts:                 Contains the interrupt information for the 
timer. The
@@ -21,7 +23,11 @@ Required properties:
                        the Samsung device uses.
  - #io-channel-cells = <1>; As ADC has multiple outputs
  - clocks              From common clock binding: handle to adc clock.
+                       From common clock binding: handle to sclk_tsadc clock
+                       if using Exynos3250.
  - clock-names         From common clock binding: Shall be "adc".
+                       From common clock binding: Shall be "sclk_tsadc"
+                       if using Exynos3250.
  - vdd-supply          VDD input supply.

  Note: child nodes can be added for auto probing from device tree.
@@ -41,6 +47,20 @@ adc: adc@12D10000 {
        vdd-supply = <&buck5_reg>;
  };

+If Exynos3250 uses ADC,

Please keep proper formatting:

Example: Node for ADC of Exynos3250 with additional special clock

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to