Naveen, On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi <ch.nav...@samsung.com> wrote: > ADC module on Exynos5 SoCs runs at 600KSPS. At this conversion rate, > waiting for 1000 msecs is wasteful (incase of h/w failure). > > Hence, reduce the time out to 100msecs and use > wait_for_completion_timeout() instead of > wait_for_completion_interruptible_timeout() > > Also, handle the return values in exynos_raw_read() call.
You probably didn't need to mention this--it's just a natural part of changing from wait_for_completion_interruptible_timeout() to wait_for_completion_timeout(). > > Change-Id: Icb8cade162094b2777c9f3c77120635deef5947c Please don't send upstream with Change-Id. Have you considered patman <http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README;hb=refs/heads/master>? > Signed-off-by: Naveen Krishna Chatradhi <ch.nav...@samsung.com> > --- > This change is a part of the patch reviewd at > https://lkml.org/lkml/2013/11/5/92 > > drivers/iio/adc/exynos_adc.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) Other than problems above, this looks fine to me. If you fix them, feel free to add my Reviewed-by tag. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
