Hello Lee,
Thanks a lot for your feedback.
On 01/20/2015 09:20 AM, Lee Jones wrote:
> On Fri, 02 Jan 2015, Javier Martinez Canillas wrote:
>
>> The ChromeOS EC character device is an user-space interface to
>> allow applications to access the Embedded Controller.
>>
>> Add a cell for this device so it's spawned from the mfd driver.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.marti...@collabora.co.uk>
>> ---
>>
>> Changes since v1: None, new patch.
>>
>> drivers/mfd/cros_ec.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
>> index c872e1b..70f9ed5 100644
>> --- a/drivers/mfd/cros_ec.c
>> +++ b/drivers/mfd/cros_ec.c
>> @@ -118,6 +118,10 @@ static const struct mfd_cell cros_devs[] = {
>> .id = 2,
>> .of_compatible = "google,cros-ec-i2c-tunnel",
>> },
>> + {
>> + .name = "cros-ec-dev",
>
> *-dev is seldom suitable for naming things.
>
> Please be more imaginative/descriptive in your naming.
>
You know this is one of the two hard problems in CS ;-)
But seriously, this is the name used in the downstream ChromiumsOS kernel
and tbh I don't think is that bad since after all is a character device
interface to access the Embedded Controller from user-space. So in that
sense is not worse than the i2c-dev or spidev names but I can try to come
up with something more creative if that will block the patch to be merged.
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
