Hi Inki, On 24 December 2015 at 09:10, Inki Dae <[email protected]> wrote: > +void exynos_drm_crtc_cancel_page_flip(struct drm_crtc *crtc) > +{ > + struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); > + unsigned long flags; > + > + spin_lock_irqsave(&crtc->dev->event_lock, flags); > + exynos_crtc->event = NULL; > + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); > +}
This will leak the event and event space; you should call event->base.destroy() here. With that fixed: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
