On Tue, Jan 25, 2005 at 07:52:42PM -0500, Ju, Seokmann wrote: > Hello, > > Here is a patch for megaraid_mbox 2.20.4.3 and megaraid_mm 2.20.2.5. > The patch includes following changes/fixes > - sysfs support for drive addition/removal > - Tape drive timeout issue > - Made some code static > > I am attaching and inlining the patch.
This patch is mangled. Long lines are wrapped, and appears to be in ISO-8859-1, such that spaces (ascii 0x20) appear as hex 0xa0. This makes it difficult to review, and impossible to apply. +// definitions for the device attributes for exporting logical drive number +// for a scsi address (Host, Channel, Id, Lun) + +CLASS_DEVICE_ATTR(megaraid_mbox_app_hndl, S_IRUSR, megaraid_sysfs_show_app_hndl, + NULL); How is this being used by your apps please? Otherwise the patch looks sane. Thanks, Matt -- Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html