On Tue, Feb 15, 2005 at 02:09:02PM +0000, Matthew Wilcox wrote:
> On Tue, Feb 15, 2005 at 10:39:59AM +0000, Christoph Hellwig wrote:
> > > - return readb(host->base + (reg^bE));
> > > + return readb((volatile void __iomem *)(host->base + (reg^bE)));
> > 
> > Again, no.  Stop casting to void __iomem pointers, please don't submit
> > a patch like this one again ever.
> 
> Actually, for 53c700, I think this *is* the right fix.  Unless we want to
> move it away from using host->base (which is marked as "legacy crap", so
> maybe we do).  I guess pushing it into hostdata is the preferred way?

Yes.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to