On Mon, Feb 28, 2005 at 09:29:20PM +0000, Christoph Hellwig wrote: > On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: > > This patch contains the following cleanups: > > - make needlessly global code static > > - kill the unused global *_version and *_version_str variables > > in the firmware files > > The firmware files are generated, so it'd be better to leave them > alone.
Agreed. But can't the generation of these files omit these needless variables (there are already #define's containing the version information)? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html