On Mon, 28 Feb 2005, James Bottomley wrote:
> On Sun, 2005-02-20 at 22:44 -0500, Alan Stern wrote:
> > James, please withdraw the patch above.
>
> Actually, I already have this in the tree. Could you just do an
> incremental to remove the blacklist line since I think the IBM people
> still want their shark fix?
You have confused two different patches. The one I asked you to withdraw
(labelled as470) does nothing but add a single line to the scsi_devinfo.c
blacklist. The reversal patch for it is below.
The other patch, the one you're thinking of, is the one that adds retries
for Hardware Error sense keys; it's labelled as468. In addition to the
IBM Shark stuff it contains a blacklist entry for a USB mass storage
device with vendor name ST650211 (marketed as an "HS200"). Although I'm
not certain, I think this device is not a USB-IDE converter -- perhaps
Radovan can clear this up for us. Anyway, there's no easy way to get the
same effect as the blacklist entry by modifying usb-storage, since the
code only looks at the blacklist setting and not anything in the
scsi_device. So I think patch as468 should remain as it stands.
Alan Stern
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
===== drivers/scsi/scsi_devinfo.c 1.14 vs edited =====
--- 1.14/drivers/scsi/scsi_devinfo.c 2004-12-10 11:54:56 -05:00
+++ edited/drivers/scsi/scsi_devinfo.c 2005-02-16 11:30:56 -05:00
@@ -201,7 +201,6 @@
{"WangDAT", "Model 2600", "01.7", BLIST_SELECT_NO_ATN},
{"WangDAT", "Model 3200", "02.2", BLIST_SELECT_NO_ATN},
{"WangDAT", "Model 1300", "02.4", BLIST_SELECT_NO_ATN},
- {"WDC WD25", "00JB-00FUA0", NULL, BLIST_NOREPORTLUN},
{"XYRATEX", "RS", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"Zzyzx", "RocketStor 500S", NULL, BLIST_SPARSELUN},
{"Zzyzx", "RocketStor 2000", NULL, BLIST_SPARSELUN},
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
