Re: [PATCH scsi-misc-2.6 03/04] scsi: make scsi_requeue_request() use blk_requeue_request()

[Christoph Hellwig]

> +     cmd->request->flags |= REQ_SOFTBARRIER;
> +
> +     spin_lock_irqsave(q->queue_lock, flags);
> +     blk_requeue_request(q, cmd->request);
> +     spin_unlock_irqrestore(q->queue_lock, flags);
>  
>       scsi_run_queue(q);

This exact code sequence is duplicated in the previous patch, maybe time
for a

void scsi_requeue_request(struct request *rq)
{
        struct request_queue *q = rq->q;
        unsigned long flags;

        rq->flags |= REQ_SOFTBARRIER;

        spin_lock_irqsave(q->queue_lock, flags);
        blk_requeue_request(q, rq);
        spin_unlock_irqrestore(q->queue_lock, flags);
  
        scsi_run_queue(q);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html