Re: [PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling.

[James Bottomley]

On Fri, 2005-08-26 at 19:08 -0700, Andrew Vasquez wrote:
>               WRT_REG_DWORD(&reg->ctrl_status,
>                   CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
> -             RD_REG_DWORD(&reg->ctrl_status);
> +             /*
> +              * It is necessary to delay here since the card doesn't respond
> +              * to PCI reads during a reset. On some architectures this will
> +              * result in an MCA.
> +             */
> +             udelay(100);

Removing the read introduces a potential write posting bug, doesn't?
And again:


> @@ -589,10 +589,14 @@ qla24xx_reset_risc(scsi_qla_host_t *ha)
>  
>         WRT_REG_DWORD(&reg->ctrl_status,
>             CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
> -       RD_REG_DWORD(&reg->ctrl_status);

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html