>>>>> "James" == James Bottomley <[EMAIL PROTECTED]> writes:

James> I think we should be going through dev_printk as the primary,
James> particularly as doing this would make the output of sdev_printk
James> different from scmd_printk.  How about

Fine with me except we're now back to having inconsistent prefixes for
the result printing and the matching sense data.

I'll try to sanitize the sense printing too and post a new patch.


James> The other nasty is that we can't actually deref rq_disk unless
James> <linux/blkdev.h> is included.  You'll find megaraid_sas.c fails
James> to compile becuase of this.  It can probably be fixed by
James> including blkdev.h from scsi_device.h

You must have had a reject on scsi_device.h.  My patch did include
<linux/blkdev.h> to fix that very issue.

-- 
Martin K. Petersen      Oracle Linux Engineering

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to