The previous commit to fix a blocking read bug put a bug that leads a
deadlock on discarding done commands. We don't need bsg_device's lock
there.

Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
 block/bsg.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/block/bsg.c b/block/bsg.c
index 2f78d7d..9b5f6d7 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -466,11 +466,8 @@ static int bsg_complete_all_commands(str
         */
        ret = 0;
        do {
-               spin_lock_irq(&bd->lock);
-               if (!bd->queued_cmds) {
-                       spin_unlock_irq(&bd->lock);
+               if (!bd->queued_cmds)
                        break;
-               }
 
                bc = bsg_get_done_cmd(bd);
                if (IS_ERR(bc))
-- 
1.4.3.2

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to